Dynamic lora load/unload sidecar #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
k8s-ci-robot
added
cncf-cla: no
|
/assign |
liu-cong
reviewed
Oct 24, 2024
guydc
reviewed
Oct 25, 2024
guydc
reviewed
Oct 25, 2024
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
k8s-ci-robot
added
size/L
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
k8s-ci-robot
added
size/XL
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
liu-cong
reviewed
Nov 5, 2024
…et changes, pull dynamically from configmap Signed-off-by: Kunjan Patel <[email protected]>
ahg-g
reviewed
Nov 11, 2024
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
|
Signed-off-by: Kunjan Patel <[email protected]>
Signed-off-by: Kunjan Patel <[email protected]>
perhaps under a tools directory? |
Signed-off-by: Kunjan <[email protected]>
Signed-off-by: Kunjan <[email protected]>
ahg-g
reviewed
Nov 16, 2024
Co-authored-by: Abdullah Gharaibeh <[email protected]>
Co-authored-by: Abdullah Gharaibeh <[email protected]>
|
/lgtm /label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, coolkp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shaneutt
pushed a commit
to shaneutt/gateway-api-inference-extension
that referenced
this pull request
Apr 18, 2025
…oyments Add CRDs deployments
kfswain
pushed a commit
to kfswain/llm-instance-gateway
that referenced
this pull request
Apr 29, 2025
* Dynamic lora load/unload sidecar * Formatting * Resolve README comments Signed-off-by: Kunjan Patel <[email protected]> * Address comments on sidecar, store updates in memory, rename base field Signed-off-by: Kunjan Patel <[email protected]> * Address comments in example deployment Signed-off-by: Kunjan Patel <[email protected]> * Address comments in example deployment Signed-off-by: Kunjan Patel <[email protected]> * base model is optional Signed-off-by: Kunjan Patel <[email protected]> * Check health of server before querying Signed-off-by: Kunjan Patel <[email protected]> * Check health of server before querying Signed-off-by: Kunjan Patel <[email protected]> * Docstrings Signed-off-by: Kunjan Patel <[email protected]> * Mock health check in tests Signed-off-by: Kunjan Patel <[email protected]> * Refactor configmap, switch to watchfiles to detect symbolic link target changes, pull dynamically from configmap Signed-off-by: Kunjan Patel <[email protected]> * Refactor configmap, switch to watchfiles to detect symbolic link target changes, pull dynamically from configmap Signed-off-by: Kunjan Patel <[email protected]> * Modify unittests Signed-off-by: Kunjan Patel <[email protected]> * Change example host and port to be explicit Signed-off-by: Kunjan Patel <[email protected]> * Change example sidecar name Signed-off-by: Kunjan Patel <[email protected]> * Add warning about using subPath Signed-off-by: Kunjan Patel <[email protected]> * Add screenshots Signed-off-by: Kunjan Patel <[email protected]> * Add screenshots Signed-off-by: Kunjan Patel <[email protected]> * Add testing results Signed-off-by: Kunjan Patel <[email protected]> * Add testing results Signed-off-by: Kunjan Patel <[email protected]> * Add config validation Signed-off-by: Kunjan Patel <[email protected]> * Add config documentation Signed-off-by: Kunjan Patel <[email protected]> * Add config documentation Signed-off-by: Kunjan Patel <[email protected]> * Add config validation Signed-off-by: Kunjan Patel <[email protected]> * Add config validation Signed-off-by: Kunjan Patel <[email protected]> * Make reconciling non blocking * Move under tools Signed-off-by: Kunjan <[email protected]> * Move under tools Signed-off-by: Kunjan <[email protected]> * Document usage of sidecar, available by default from 1.29 * Document usage of sidecar, available by default from 1.29 * Document usage of sidecar, available by default from 1.29 Signed-off-by: Kunjan <[email protected]> * Update tools/dynamic-lora-sidecar/README.md Co-authored-by: Abdullah Gharaibeh <[email protected]> * Update tools/dynamic-lora-sidecar/README.md Co-authored-by: Abdullah Gharaibeh <[email protected]> --------- Signed-off-by: Kunjan Patel <[email protected]> Signed-off-by: Kunjan <[email protected]> Co-authored-by: Abdullah Gharaibeh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding sidecar example for dynamically managing lora adapters on vllm server